-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A little fix #3
base: cm-11.0-wip
Are you sure you want to change the base?
A little fix #3
Conversation
Revert changes
Launch QMUXD as radio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes look like from newer android versions, please elaborate more detailed comments for your commits if the change is reasonable.
@@ -28,8 +28,8 @@ TARGET_CPU_SMP := true | |||
TARGET_CPU_VARIANT := krait | |||
TARGET_ARCH_VARIANT := armv7-a-neon | |||
|
|||
TARGET_GLOBAL_CFLAGS += -mtune=cortex-a7 -mfpu=neon-vfpv4 -mfloat-abi=softfp | |||
TARGET_GLOBAL_CPPFLAGS += -mtune=cortex-a7 -mfpu=neon-vfpv4 -mfloat-abi=softfp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to use clang with cm-11.0? I don't think this is correct. @vm03 do you have any ideas?
@@ -37,6 +37,9 @@ PRODUCT_PACKAGES += \ | |||
tinymix \ | |||
tinyplay | |||
|
|||
|
|||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add empty lines
@@ -604,7 +544,7 @@ int camera_device_open(const hw_module_t* module, const char* name, | |||
memset(camera_ops, 0, sizeof(*camera_ops)); | |||
|
|||
camera_device->base.common.tag = HARDWARE_DEVICE_TAG; | |||
camera_device->base.common.version = 0; | |||
camera_device->base.common.version = CAMERA_DEVICE_API_VERSION_1_0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this api exist in cm-11?
@@ -90,7 +90,7 @@ | |||
<bool name="config_bluetooth_le_peripheral_mode_supported">true</bool> | |||
|
|||
<!-- Boolean indicating whether Softap requires reloading AP firmware --> | |||
<bool name="config_wifiApFirmwareReload">false</bool> | |||
<add-resource type="bool" name="config_wifiApFirmwareReload">false</add-resource> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does cm-11 support add-resource-type? Same to all bellow
@@ -345,7 +345,7 @@ on property:bluetooth.hciattach=false | |||
service qmuxd /system/bin/qmuxd | |||
class main | |||
user radio | |||
group radio audio bluetooth gps qcom_diag | |||
group radio audio bluetooth gps qcom_diag log wakelock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct for cm-11?
No description provided.